Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix dart_sdk packaging name.#31942

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:fix_dart_packaging
Mar 10, 2022
Merged

Fix dart_sdk packaging name.#31942
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:fix_dart_packaging

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 10, 2022 •
edited
Loading

The previous name was referencing mac instead of the expected darwin.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Fix dart_sdk packaging name.
0b6f8dc 
The previous name was referencing mac instead of the expected darwin.

Bug: flutter/flutter#90476
@godofredoc godofredoc requested review from dnfield and zanderso March 10, 2022 04:18
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 10, 2022
@fluttergithubbot fluttergithubbot merged commit cb3904f into flutter:main Mar 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
cb3904f Fix dart_sdk packaging name. (flutter/engine#31942)
abf5b8d
@godofredoc godofredoc deleted the fix_dart_packaging branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @zanderso @fluttergithubbot