Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ci.yaml] Migrate remaining targets to cocoon scheduler#32018

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
CaseyHillers:cocoon-100
Mar 15, 2022
Merged

[ci.yaml] Migrate remaining targets to cocoon scheduler#32018
fluttergithubbot merged 1 commit intoflutter:mainfrom
CaseyHillers:cocoon-100

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Mar 14, 2022

flutter/flutter#92300

This moves the rollout from 30% to 100% (adding 25 targets).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@CaseyHillers CaseyHillers mentioned this pull request Mar 14, 2022
Closed
19 tasks
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Mar 15, 2022

Note: This is something to be landed in off peak hours

keyonghan
keyonghan approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 15, 2022
@fluttergithubbot fluttergithubbot merged commit 5a80834 into flutter:main Mar 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2022
@engine-flutter-autoroll
5a80834 [ci.yaml] Migrate remaining targets to cocoon scheduler (flut…
6b254a7 
…ter/engine#32018)
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 16, 2022
@engine-flutter-autoroll
Roll Engine from 3d59739 to dc22c4c (8 revisions) (#100179)
301822f 
* 0199e90 [macOS] fix text selection when there's composing text  (flutter/engine#31936)

* 0ca0ce1 Roll Skia from 9565f4bd902b to a48a3c9417c0 (3 revisions) (flutter/engine#32044)

* a60e8c3 Switch the renderer to impeller based on the presence of a command line flag. (flutter/engine#31959)

* 24051b6 Roll Fuchsia Mac SDK from EOVjR8JSN... to jvlI1s78T... (flutter/engine#32047)

* fef6232 Roll Skia from a48a3c9417c0 to ffb49630eb1a (3 revisions) (flutter/engine#32048)

* 5a80834 [ci.yaml] Migrate remaining targets to cocoon scheduler (flutter/engine#32018)

* cd7a1e2 Support stencil buffers on OpenGL for Windows and Android (flutter/engine#31967)

* dc22c4c Add DlColorSource objects to hold information for SkShaders (flutter/engine#31981)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @keyonghan @fluttergithubbot