This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux, Keyboard] Extract KeyboardManager's external dependencies as ViewDelegate; Rework testing framework#32305
Merged
fluttergithubbot merged 11 commits intoflutter:mainfrom Apr 12, 2022
Conversation
A test passes less changes Redispatch uses unique_ptr DisposeWithUnresolvedPends first half of SingleDelegateWithAsyncResponds Use idle to implement pending Rename to flushChannelMessages EmbedderCallRecord SingleDelegateWithAsyncResponds EXPECT_FALSE(during_redispatch_) EXPECT_KEY_EVENT CallRecord All tests Format
dkwingsmt
force-pushed
the
linux-key-delegate
branch
from
3696bd8 to
ba8573e
Compare
dkwingsmt
changed the title
dkwingsmt
changed the title
gspencergoog
approved these changes
Apr 12, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
This is much nicer. Just some documentation nits.
Co-authored-by: Greg Spencer <[email protected]>
… linux-key-delegate
dkwingsmt
added
affects: text input
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2022
…cies as ViewDelegate; Rework testing framework (flutter/engine#32305)
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
…ViewDelegate; Rework testing framework (flutter#32305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
FlKeyboardManageran all-in-one component that encapsulates the entire keyboard system, and reworks the testing framework to support such changes.All of
FlKeyboardManager's external dependencies are now extracted asFlKeyboardViewDelegate, which is implemented byFlView. The keyboard responders are now created and managed by the manager, instead of the view. In this way, the view is no longer aware of any implementation details, but only what the manager needs from outside.Moreover, the testing framework has been reworked. The new framework mocks and compares the end result of the manager's effects, i.e. the engine and the messenger. It also adopts the latest "class-based" design.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.