This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Macos deltas composing fix#32345
Merged
Renzo-Olivares merged 9 commits intoflutter:mainfrom Mar 31, 2022
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
justinmc
approved these changes
Mar 31, 2022
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for the really thorough test, it's clearly needed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the incorrect composing region was sent as a delta to the framework, causing no delta to be created on the framework side because the delta range did not exist. Sending the correct composing region also fixes inserting of special characters with opt+n / opt+u
Also updated
testOperationsWithDeltatestOld:
New:
When
setMarkedTextis called at this point in the test, it is the beginning of composition so the text will be inserted at the collapsed selection.deltaStartanddeltaEndwas previously set to the range of the new composing region, but this is incorrect because the range of(14,25)does not exist in the text before this delta is applied.Fixes flutter/flutter#101013
Added
testComposingWithDeltaPre-launch Checklist
writing and running engine tests.
///).