This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] Make unit tests abort on critical errors, and fix two such errors#32348
Merged
fluttergithubbot merged 4 commits intoflutter:mainfrom Apr 28, 2022
Merged
Conversation
7ebca6f to
bd1fd33
Compare
chinmaygarde
approved these changes
Apr 28, 2022
bd1fd33 to
5cc721e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes GTK unit tests abort on GTK critical errors. This including GTK internal errors and
g_return_if_failstatements added by Flutter. This PR also fixes three such critical errors that have been ignored.These
g_return_if_failstatements have been used as (and practically are) the GTK version ofasserts. However, currently these statements only logs to stderr, while the process goes on with a return value 0, making them pretty much ignored.I've tried to look for a way to only return a non-zero value instead of aborting, but in vain.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.