This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added workaround for ios safari iframe issue#32415
Merged
nbayati merged 7 commits intoflutter:mainfrom May 17, 2022
Merged
Conversation
yjbanov
reviewed
Apr 4, 2022
mdebbar
reviewed
May 11, 2022
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
There seem to be some build errors:
error - test/canvaskit/semantics_test.dart:28:12 - Undefined name 'isIosSafari'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
error - test/engine/semantics/semantics_test.dart:18:8 - Target of URI doesn't exist: '../../common.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
|
Gold has detected about 8 new digest(s) on patchset 15. |
Contributor
|
It looks like the cleanup didn't fix the failure. I spent some time this morning debugging the test failure and found the problem. The cleanup that you did is necessary, but it's not working because the listeners are stored as static members: engine/lib/web_ui/lib/src/engine/pointer_binding.dart Lines 161 to 165 in 1d0c2ae That means all PointerBinding/Adapter instances are sharing the same map of listeners. If you remove |
mdebbar
reviewed
May 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a workaround for ios Safari by adding a dummy event listener.
Fixes: flutter/flutter#70858
Fixes: flutter/flutter#101251
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.