This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Only install iOS simulator runtimes on builders that use them#32416
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom Apr 8, 2022
Merged
Only install iOS simulator runtimes on builders that use them#32416fluttergithubbot merged 1 commit intoflutter:mainfrom
fluttergithubbot merged 1 commit intoflutter:mainfrom
Conversation
jmagman
commented
Apr 5, 2022
| [ | ||
| {"name":"flutter_cocoapods","path":"cocoapods"}, | ||
| {"name":"osx_sdk_13a233_13_15","path":"osx_sdk"}, | ||
| {"name":"osx_sdk_13a233","path":"osx_sdk"}, |
Member
Author
There was a problem hiding this comment.
@godofredoc do you think this is the right thing to do here to avoid the caches from colliding? Hopefully we don't have that problem once you are done the symlinking fixes.
Contributor
There was a problem hiding this comment.
If I understand mac_toolchain correctly we don't need to differentiate between xcode and runtimes because they use different caches. In other words once the symlink changes land we will be able to keep a single cache per xcode version and single caches per runtime.
zanderso
approved these changes
Apr 8, 2022
Member
Author
|
Holding off on this until @godofredoc is done his simulator symlink investigation. |
godofredoc
approved these changes
Apr 8, 2022
jmagman
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS 13 and 15 runtime simulators are only needed for
Mac Unoptat the moment. Removeruntime_versionsas default on Mac builders and only set the property where needed. This should reduce the build time by ~4 minutes per builder.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.