Pin dockerfile version.#32418
Pin dockerfile version.#32418fluttergithubbot merged 6 commits intoflutter:mainfrom godofredoc:pin_docker
Conversation
ci/docker/build/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM debian:stretch | |||
| FROM debian:bullseye-slim@sha256:82da53aa627b9d5032a1e57903356b8f34d613a5bc1e07ae5e9149bd88fa3128 | |||
There was a problem hiding this comment.
In the past, it looks like this was updated to match the LUCI / Framework version: #25009.
Is that also what is happening here?
There was a problem hiding this comment.
Sorry somehow I didn't see this question. LUCI is still on stretch, I can get it back to stretch with the pinned version or we can be proactive and use the Ubuntu version Dart is currently using and that we are planning to migrate to. What option do you think will work better?
There was a problem hiding this comment.
Can this file take comments, or is there a readme in this directory that can be updated to explain what's going on? Being proactive sgtm, but how will this get updated to match in the future?
There was a problem hiding this comment.
Yes, it supports comments. As long as they are on the same major version the minor updates will be applied by dependabot in this file and by apt-get upgrade on the VMs.
| mtools \ | ||
| nasm \ | ||
| net-tools \ | ||
| openjdk-8-jdk \ |
There was a problem hiding this comment.
Why are these being removed? Are they no longer needed, or do they appear in the new image by default?
There was a problem hiding this comment.
They do not exist on the default packages anymore and seem like they are not needed. Waiting for the cirrus test to complete to validate they are not needed anymore.
There was a problem hiding this comment.
Confirmed that they are not needed anymore.
This is part of the security effort to pin all the docker dependencies across all the flutter repositories.
|
@zanderso config file updated to use ubuntu:bionic and it is ready for review. |
godofredoc
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
chinmaygarde
added
the
waiting for tree to go green
4 participants
This is part of the security effort to pin all the docker dependencies
across all the flutter repositories.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.