Don't use Skia internal src file GrGLDefines.#32491
Don't use Skia internal src file GrGLDefines.#32491chinmaygarde merged 3 commits intoflutter:mainfrom
Conversation
Skia's src files are not stable and may change constantly, flutter should not ever including them.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@chinmaygarde @brianosman I can't add reviewers so doing via comments :) |
zanderso
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Skia's src files are not stable and may change constantly, flutter should not ever including them.
5 participants
Skia's src files are not stable and may change constantly, flutter should not ever including them.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.