Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update os dimension for engine v2 builders.#32571

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:update_mac_new_builders
Apr 12, 2022
Merged

Update os dimension for engine v2 builders.#32571
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:update_mac_new_builders

Conversation

@godofredoc
Copy link
Contributor

Engine V2 builders are failing since the version of xcode was updated to
13 because the current os dimension is set to Mac which allows builds to
pick Mac-10 bots that are not compatible with Xcode 13.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Engine V2 builders are failing since the version of xcode was updated to
13 because the current os dimension is set to Mac which allows builds to
pick Mac-10 bots that are not compatible with Xcode 13.
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 11, 2022
@fluttergithubbot fluttergithubbot merged commit 0fad802 into flutter:main Apr 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
@godofredoc godofredoc deleted the update_mac_new_builders branch April 19, 2022 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants