This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix races associated with unawaited futures#32593
Merged
yjbanov merged 1 commit intoflutter:mainfrom Apr 12, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
platform-web
eyebrowsoffire
approved these changes
Apr 12, 2022
ditman
reviewed
Apr 12, 2022
| if (missingCodeUnits.isNotEmpty || unmatchedCodeUnits.isNotEmpty) { | ||
| if (!data.registeredSymbolsAndEmoji) { | ||
| _registerSymbolsAndEmoji(); | ||
| await _registerSymbolsAndEmoji(); |
Member
There was a problem hiding this comment.
This looks like a fix for 10s of emoji-related issues :P
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
unawaited_futureslint for all web engine code, and fix code that's been ignoring the futures. In particular, this should fix test flakiness on Firefox, such as this.