Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll buildroot to 60d942d91bf97e9c9f0876fb54d6cfba77c17dfb#32663

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
cbracken:roll-buildroot
Apr 14, 2022
Merged

Roll buildroot to 60d942d91bf97e9c9f0876fb54d6cfba77c17dfb#32663
fluttergithubbot merged 1 commit intoflutter:mainfrom
cbracken:roll-buildroot

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 13, 2022

Issue: flutter/flutter#59199

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Roll buildroot to 60d942d
852bce8 
* [win32] Suppress win32 swiftshader warnings (flutter/buildroot#562)
* [win32] Use clang cflags on Windows builds (flutter/buildroot#561)

Issue: flutter/flutter#59199
@cbracken cbracken requested a review from jason-simmons April 13, 2022 23:25
dkwingsmt
dkwingsmt approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 14, 2022
@fluttergithubbot fluttergithubbot merged commit 08bfee8 into flutter:main Apr 14, 2022
@cbracken cbracken deleted the roll-buildroot branch April 14, 2022 00:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
08bfee8 Roll buildroot to 60d942d (flutter/engine#32663)
c1afc2f
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@cbracken @justinmc
Roll buildroot to 60d942d (flutter#32663)
49e46fd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @dkwingsmt @fluttergithubbot