This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux, Keyboard] Derive keyboard layout using printable information from system #32665
Merged
dkwingsmt merged 14 commits intoflutter:mainfrom Apr 21, 2022
Merged
Conversation
flutter-dashboard
bot
added
embedder
Co-authored-by: Greg Spencer <[email protected]>
dkwingsmt
added
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2022
…rmation from system (flutter/engine#32665)
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how Flutter derives logical keys on Linux. By gathering the keyboard layout information and analyzing them as a whole, Flutter can build the key map and fix problems that can not be overcome by calculating on a per-key basis.
This PR is parallel to #32152, using the same algorithm, and should result in a similar (if not identical) layout.
This addresses the first phase of flutter/flutter#100456 on Linux, but requires an additional PR to apply to RawKeyboard and Shortcut.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.