This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[dart_test_runner] Adapt the dart runner to implement the suite fidl protocol so that it can be used the the v2 testing framework.#32751
Merged
akbiggs merged 1 commit intoflutter:mainfrom Apr 28, 2022
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
naudzghebre
force-pushed
the
dart_runner
branch
from
06b3941 to
6f29834
Compare
akbiggs
reviewed
Apr 18, 2022
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.h
Outdated
Show resolved
Hide resolved
naudzghebre
force-pushed
the
dart_runner
branch
2 times, most recently
from
9422b58 to
03b9e64
Compare
akbiggs
reviewed
Apr 18, 2022
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.h
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.h
Outdated
Show resolved
Hide resolved
naudzghebre
force-pushed
the
dart_runner
branch
from
03b9e64 to
da9808b
Compare
akbiggs
reviewed
Apr 19, 2022
naudzghebre
force-pushed
the
dart_runner
branch
from
da9808b to
2935eb3
Compare
chaselatta
approved these changes
Apr 19, 2022
akbiggs
approved these changes
Apr 19, 2022
naudzghebre
force-pushed
the
dart_runner
branch
3 times, most recently
from
6d4e1c8 to
2c79c03
Compare
naudzghebre
force-pushed
the
dart_runner
branch
4 times, most recently
from
09a08c0 to
f759323
Compare
chaselatta
approved these changes
Apr 27, 2022
naudzghebre
force-pushed
the
dart_runner
branch
3 times, most recently
from
1b6e4dd to
1666bb5
Compare
naudzghebre
force-pushed
the
dart_runner
branch
from
1666bb5 to
8106c40
Compare
…protocol so that it can be used in the v2 testing framework.
naudzghebre
force-pushed
the
dart_runner
branch
from
8106c40 to
67075c8
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
…te fidl protocol so that it can be used in the v2 testing framework. (flutter/engine#32751)
github-actions bot
pushed a commit
to gnoliyil/fuchsia
that referenced
this pull request
May 24, 2022
- The dart runner implements the suite protocol as of : flutter/engine#32751. - This cl attaches the test_runtime shard to all dart v2 tests. - An example hello world test is included. - Tests using dart_test_wrapper_component() build rule are replaced with this implementation. Bug: 92745 Change-Id: I27e53622c52b1265759e04e7eb096f9de434d814 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/660762 Reviewed-by: Ankur Mittal <[email protected]> Commit-Queue: Naud Ghebre <[email protected]> Reviewed-by: Alexander Biggs <[email protected]> Reviewed-by: Allison Pearce <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Suite protocol on behalf of the test component in the dart runner.