Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll ANGLE to 90d18b0391065b7ecc556ccfce1201aa6392e22d#32759

Merged
cbracken merged 1 commit intoflutter:mainfrom
cbracken:roll-angle
Apr 19, 2022
Merged

Roll ANGLE to 90d18b0391065b7ecc556ccfce1201aa6392e22d#32759
cbracken merged 1 commit intoflutter:mainfrom
cbracken:roll-angle

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 18, 2022

This rolls ANGLE to the most recent commit that compiles cleanly before
the build was refactored to support SwANGLE on ChromeCast, which
requires some buildroot tweaking to build with Flutter.

Issue: flutter/flutter#102117

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog
gspencergoog approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@cbracken
Roll ANGLE to 90d18b0391065b7ecc556ccfce1201aa6392e22d
122b231 
This rolls ANGLE to the most recent commit that compiles cleanly before
the build was refactored to support SwANGLE on ChromeCast, which
requires some buildroot tweaking to build with Flutter.

Issue: flutter/flutter#102117
@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 19, 2022
@cbracken cbracken merged commit 6e409e6 into flutter:main Apr 19, 2022
@cbracken cbracken deleted the roll-angle branch April 19, 2022 01:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2022
@engine-flutter-autoroll
6e409e6 Roll ANGLE to 90d18b0391065b7ecc556ccfce1201aa6392e22d (flutt…
2e8f903 
…er/engine#32759)
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@cbracken @justinmc
Roll ANGLE to 90d18b0391065b7ecc556ccfce1201aa6392e22d (flutter#32759)
603f2f8 
This rolls ANGLE to the most recent commit that compiles cleanly before
the build was refactored to support SwANGLE on ChromeCast, which
requires some buildroot tweaking to build with Flutter.

Issue: flutter/flutter#102117
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @gspencergoog