This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Switch FML_DLOGs -> FML_LOGs.#32760
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom Apr 19, 2022
Merged
Conversation
arbreng
approved these changes
Apr 18, 2022
FML_DLOG only works on unoptimized builds but our Flutter runner is never built in unoptimized mode, so we miss out on a lot of error logs as a result. This change allows developers to see those log messages without introducing performance regressions to dev builds of our Flutter runner.
Contributor
Author
|
Thanks David, removed the spammy ones. |
akbiggs
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FML_DLOG only works on unoptimized builds (fxb/93877)
but our Flutter runner is never built in
unoptimized mode, so we miss out on a lot of error logs as a result. This
change allows developers to see those log messages without risk of
introducing performance regressions to dev builds of our Flutter runner
(and also I need that unoptimized build for ASAN).