Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web]: update libraries.json to use the include feature.#32874

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
sigmundch:reapply
Apr 28, 2022
Merged

[web]: update libraries.json to use the include feature.#32874
fluttergithubbot merged 1 commit intoflutter:mainfrom
sigmundch:reapply

Conversation

@sigmundch
Copy link
Contributor

This reapplies e630093 (reverted in 734169c). It was initially reverted because it broke rolls internally. We've addressed the issues identified in the previous roll with changes to the internal build rules (cl/426422236), so we are ready to try to land this again.

/cc @johnniwinther

This reapplies e630093 (reverted in
734169c). It was initially reverted
because it broke rolls internally. We've addressed the issues identified
in the previous roll with changes to the internal build rules, so we
are ready to try to land this again.
@sigmundch sigmundch requested review from angjieli and yjbanov April 22, 2022 20:59
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 22, 2022
@sigmundch
Copy link
Contributor Author

@yjbanov friendly ping

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sigmundch sigmundch added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 28, 2022
@fluttergithubbot fluttergithubbot merged commit 884aa38 into flutter:main Apr 28, 2022
@sigmundch sigmundch deleted the reapply branch April 28, 2022 22:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants