This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Migrate unittests to CFv2#32878
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom May 7, 2022
Merged
Conversation
akbiggs
approved these changes
Apr 22, 2022
Contributor
akbiggs
left a comment
akbiggs
left a comment
There was a problem hiding this comment.
a simpler workflow sgtm!
Contributor
|
Looks like there's one more test that's failing here: |
Contributor
|
Any progress on the failing test? |
arbreng
changed the title
Contributor
Author
|
Yep, all fixed! As a bonus, I added the display_list_unittests and display_list_render_tests to run on fuchsia |
akbiggs
approved these changes
May 6, 2022
Add the new display_list tests so they can be run on Fuchsia. Split out the runner_unittest into it's own executable, as it relies on process-wide ICU state which conflicts with fuchsia_intl_test.cc The WarmuoSkp test is covered downstream by performance tests, and it would be difficult to port this to CFv2 as-is without resorting to hacks. These changes improve our test workflow by allowing all unittests to be run using "ffx test"!
arbreng
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new display_list tests so they can be run on Fuchsia.
Split out the runner_unittest into it's own executable, as it relies on
process-wide ICU state which conflicts with fuchsia_intl_test.cc
The WarmuoSkp test is covered downstream by performance tests, and it
would be difficult to port this to CFv2 as-is without resorting to
hacks.
These changes improve our test workflow by allowing all unittests to
be run using "ffx test"!