Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enable RasterCache for clipper layers using saveLayer#32899

Merged
fluttergithubbot merged 8 commits intoflutter:mainfrom
wangying3426:feat_cache_replace_save_layer
May 17, 2022
Merged

Enable RasterCache for clipper layers using saveLayer#32899
fluttergithubbot merged 8 commits intoflutter:mainfrom
wangying3426:feat_cache_replace_save_layer

Conversation

@wangying3426
Copy link
Contributor

@wangying3426 wangying3426 commented Apr 25, 2022 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@wangying3426 wangying3426 mentioned this pull request Apr 25, 2022
Merged
8 tasks
@wangying3426 wangying3426 changed the title RasterCache is supported for parts of the layer using saveLayer Enable RasterCache for clipper layers using saveLayer Apr 25, 2022
@zanderso zanderso requested review from dnfield and flar April 25, 2022 19:55
flar
flar approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine other than the irony of spending effort on the deprecated PhysicalShapeLayer. We should probably remove it, but I think it needs to stay in case any apps are managing their own scene building from custom RenderObjects.

See flutter/flutter#102274 for more info on why PSL was recently deprecated.

flar
flar suggested changes May 6, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benchmark already part of the flutter/flutter benchmarks that measures the gain for this? If not, then we need to create one before this PR is merged.

@wangying3426
Copy link
Contributor Author

wangying3426 commented May 7, 2022

Is there any benchmark already part of the flutter/flutter benchmarks that measures the gain for this? If not, then we need to create one before this PR is merged.

@flar Here is the benchmark flutter/flutter#102495

@wangying3426 wangying3426 requested a review from flar May 7, 2022 02:44
wangying3426 and others added 3 commits May 9, 2022 09:41
@wangying3426
Merge branch 'flutter:main' into feat_cache_replace_save_layer
27added
@wangying3426
Merge branch 'main' into feat_cache_replace_save_layer
51ba242 
# Conflicts:
#	flow/layers/clip_path_layer.cc
#	flow/layers/clip_path_layer.h
#	flow/layers/clip_rect_layer.cc
#	flow/layers/clip_rect_layer.h
#	flow/layers/clip_rrect_layer.cc
#	flow/layers/clip_rrect_layer.h
@wangying3426
Merge branch 'flutter:main' into feat_cache_replace_save_layer
674c072
@wangying3426
Copy link
Contributor Author

wangying3426 commented May 16, 2022 •
edited
Loading

Is there any benchmark already part of the flutter/flutter benchmarks that measures the gain for this? If not, then we need to create one before this PR is merged.

hi, @flar. The benchmark (flutter/flutter#102495) has been merged. At the same time, because of #32889 has been merged, some conflicts are also resolved.

flar
flar approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangying3426 wangying3426 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 17, 2022
@fluttergithubbot fluttergithubbot merged commit edd0b81 into flutter:main May 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2022
@engine-flutter-autoroll
edd0b81 Enable RasterCache for clipper layers using saveLayer (flutte…
a1c8023 
…r/engine#32899)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@wangying3426 @houhuayong
Enable RasterCache for clipper layers using saveLayer (flutter#32899)
7bb2c74
@jonahwilliams jonahwilliams mentioned this pull request Nov 24, 2023
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@flar flar flar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangying3426 @flar @fluttergithubbot