This patch is breaking rendering in impeller. Need to look into this some more.

I suspect flutter/impeller#143 broke rendering, but had to revert flutter/impeller#145 to verify so it could be either or some combination of both. @bdero fyi

These were added in https://github.com/flutter/engine/pull/3282/files#diff-c5ad14ed18025fdd922d2c53c4f7709642981eac478b0b44057466de136310a9R22 and seem to never have been used for anything. My best guess is that it was missed in reviewing a relatively large patch.

@dnfield is this still needed?

This was causing a crash when impeller was doing something broken at one point. I still think we should remove it for the reasons Chinmay says, and because all implementations of the callback simply early return false when they get called this way.

This pull request is not suitable for automatic merging in its current state.

• The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

Cirrus got confused because I closed this PR at one point - rerun here, not sure if it'll update in the UI: https://cirrus-ci.com/task/5227988034781184

This fixes a crash that happens whenever something in Impeller decides to fail a frame render (by returning false in a render callback). We'll most likely run into cases where a frame or two will fail to render as a failsafe (whether due to a nuanced bug or intentionally), so this is an important fix IMO!