This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS spell-checker ObjC#32941
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom May 19, 2022
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SpellCheck Objective C code in engine. This is part of flutter/flutter#34688
The PR can be landed standalone, it does not affect or add features to the current Flutter.
This PR adds a
FlutterSpellCheckPlugintoFlutterEngine. This plugin uses a method channel to communicate with dart. The plugin currently has one method:SpellCheck.initiateSpellCheck, which looks for the first misspelled word in the argument String and returns a result map:Design doc: https://docs.google.com/document/d/10Lvkz802QpzAGFi3Q9WVTMVUV-SPJyG3_xs8XfxG59Q/edit?usp=sharing
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.