This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove Windows UWP Engine target#33012
Merged
cbracken merged 1 commit intoflutter:mainfrom Apr 29, 2022
cbracken:remove-uwp-builder
Merged
Remove Windows UWP Engine target#33012cbracken merged 1 commit intoflutter:mainfrom cbracken:remove-uwp-builder
cbracken merged 1 commit intoflutter:mainfrom
cbracken:remove-uwp-builder
Conversation
Removes the Windows UWP Engine target from CI. UWP support was removed from the tool in: https://flutter-review.googlesource.com/c/recipes/+/29500 UWP support will be removed from the recipe in: https://flutter-review.googlesource.com/c/recipes/+/29500 UWP infra will be removed in a future patch. Issue: flutter/flutter#102172
CaseyHillers
approved these changes
Apr 29, 2022
godofredoc
approved these changes
Apr 29, 2022
cbracken
added
the
waiting for tree to go green
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
8 tasks
cbracken
added a commit
that referenced
this pull request
Apr 30, 2022
This removes: * The Windows UWP emebedder sources and targets * UWP-specific build targets * UWP-specific code behind WINUWP #ifdefs * UWP-specific TODOs. * uwptool.exe sources and targets used for installing, uninstalling, and launching UWP apps. This is a straight removal patch, and does not land any refactorings made possible by removal of UWP support. Those patches will land in followup refactorings. Tool support was removed in: flutter/flutter#102174 The CI target was removed in: #33012 The Recipe was removed in: https://flutter-review.googlesource.com/c/recipes/+/29500 GN build support was removed in: #33016 Issue: flutter/flutter#102172
godofredoc
added a commit
that referenced
this pull request
May 24, 2022
* 'Update Dart SDK to a6465a4' * Swap engine builds from Debian to Ubuntu. (#33498) * Update licenses hash. * Remove Windows UWP Engine target (#33012) Removes the Windows UWP Engine target from CI. UWP support was removed from the tool in: https://flutter-review.googlesource.com/c/recipes/+/29500 UWP support will be removed from the recipe in: https://flutter-review.googlesource.com/c/recipes/+/29500 UWP infra will be removed in a future patch. Issue: flutter/flutter#102172 * WinUWP: remove uses of build_windows_uwp (#33015) Co-authored-by: yusuf-goog <[email protected]> Co-authored-by: Chris Bracken <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Windows UWP Engine target from CI.
UWP support was removed from the tool in:
https://flutter-review.googlesource.com/c/recipes/+/29500
UWP support will be removed from the recipe in:
https://flutter-review.googlesource.com/c/recipes/+/29500
UWP infra will be removed in a future patch.
Issue: flutter/flutter#102172
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.