This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fml] Handle absolute paths on Windows#33029
Merged
zanderso merged 1 commit intoflutter:mainfrom Apr 30, 2022
Merged
Conversation
dnfield
approved these changes
Apr 30, 2022
zanderso
force-pushed
the
file-win-fixes
branch
from
a5327b7 to
6489ed3
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Posix implementation of this API, when both a base directory and an absolute path are provided, the base directory is ignored. This is because they are implemented with the
*at()family of functions. See for example https://linux.die.net/man/2/openat.This PR provides the same behavior on Windows.
Prior to this PR, the behavior is pasting the absolute path on the end of the absolute path of the base directory, which is causing impellerc to fail to write its output in tests on Windows.