Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use empty in place of size checks vs 0#33151

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
cbracken:running-on-empty
May 6, 2022
Merged

Use empty in place of size checks vs 0#33151
fluttergithubbot merged 1 commit intoflutter:mainfrom
cbracken:running-on-empty

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 5, 2022 •
edited
Loading

While size() on std::string, std::vector, std::deque, std::map are
specified to be a constant time lookup as of C++11, this improves
readability of checks for empty strings and containers, plus it's very
marginally shorter.

No test changes since there are no semantic changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken added the Work in progress (WIP) Not ready (yet) for review! label May 5, 2022
@cbracken cbracken changed the title Use empty() in place of size() == 0 Use empty() in place of size() checks vs 0 May 5, 2022
@cbracken cbracken changed the title Use empty() in place of size() checks vs 0 Use empty in place of size() checks vs 0 May 5, 2022
@cbracken cbracken changed the title Use empty in place of size() checks vs 0 Use empty in place of size checks vs 0 May 5, 2022
@cbracken
Use empty() in place of size() == 0
1714aae 
While size() on std::string, std::vector, std::deque, std::map are
specified to be a constant time lookup as of C++11, this improves
readability of checks for empty strings and containers, plus it's very
marginally shorter.
@cbracken cbracken requested a review from jason-simmons May 6, 2022 19:22
@cbracken cbracken removed the Work in progress (WIP) Not ready (yet) for review! label May 6, 2022
@cbracken
Copy link
Member Author

cbracken commented May 6, 2022

Cleanup based on feedback on another patch.

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2022
@fluttergithubbot fluttergithubbot merged commit e23c431 into flutter:main May 6, 2022
@cbracken cbracken deleted the running-on-empty branch May 6, 2022 20:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 6, 2022
@engine-flutter-autoroll
e23c431 Use empty in place of size checks vs 0 (flutter/engine#33151)
a2cbcd3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API platform-android platform-fuchsia platform-ios platform-macos platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @jason-simmons @fluttergithubbot