This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[gn] Extract target_os, target_cpu resolution#33238
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom May 10, 2022
cbracken:extract-target-os-cpu-reland
Merged
[gn] Extract target_os, target_cpu resolution#33238fluttergithubbot merged 1 commit intoflutter:mainfrom cbracken:extract-target-os-cpu-reland
fluttergithubbot merged 1 commit intoflutter:mainfrom
cbracken:extract-target-os-cpu-reland
Conversation
This is a minor refactoring to extract functions that resolve target_os and target_cpu gn settings. This is cleanup prior to adding support for host builds on Apple Silicon Macs. Issue: flutter/flutter#96745 This is a reland of #33224 That patch was reverted in #33231 On non-host Windows builds (e.g. android builds of gen_snapshot) target_cpu is rewritten to either x86 or x64. However, dart_target_arch should remain the original target_cpu (e.g. arm or arm64). The previous version of this refactor inlined that logic into get_target_cpu() which happens before we set dart_target_arch, thus incorrectly causing gen_snapshot to be built to target x86 or x64 instead of the original target architecture.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
This was referenced May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring to extract functions that resolve target_os
and target_cpu gn settings.
This is cleanup prior to adding support for host builds on Apple Silicon
Macs.
Issue: flutter/flutter#96745
This is a reland of #33224
That patch was reverted in #33231
On non-host Windows builds (e.g. android builds of gen_snapshot)
target_cpu is rewritten to either x86 or x64. However, dart_target_arch
should remain the original target_cpu (e.g. arm or arm64). The previous
version of this refactor inlined that logic into get_target_cpu() which
happens before we set dart_target_arch, thus incorrectly causing
gen_snapshot to be built to target x86 or x64 instead of the original
target architecture.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.