[Impeller] Fix sampling mode conversion for Metal#33249
[Impeller] Fix sampling mode conversion for Metal#33249fluttergithubbot merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
changed the title
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Is this fixing a test that's just not currently failing? Change looks good but we should have a test (and if we do have a test, I think we're already working on how to make them fail more clearly when they're failing...)
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Oh wow, that was just turning into a cast.
chinmaygarde
added
the
waiting for tree to go green
4 participants
Noticed this because
kRepeatwasn't working when I tried to rely on it in the new demo shader.