This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Implement toGpuImage, a synchronous, GPU-resident version of #33736
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
67325b1
Implement toGpuImage, a synchronous, GPU-resident version of
dnfield 13a25bf
merge
dnfield 76b7e8e
Merge remote-tracking branch 'upstream/main' into gpu_promise_img
dnfield 86f9f1f
fix tests, make toGpuImage do something on flutter_tester
dnfield 3bf1247
test
dnfield 711479f
Merge remote-tracking branch 'upstream/main' into gpu_promise_img
dnfield 169de25
format
dnfield 7aa625a
missing docs and mirror API in web
dnfield f727e50
simplify test for firefox
dnfield 0f0cf9f
tryAlloc
dnfield e4fbe83
fix test
dnfield 50793f3
Update canvas_test.dart
dnfield edaaeb8
merge
dnfield 2864649
Merge branch 'gpu_promise_img' of github.com:dnfield/engine into gpu_…
dnfield ea4d54d
Scene.toGpuImage
dnfield ad9225c
oops
dnfield f307e6f
...
dnfield b42bad6
fix compilation issues for real
dnfield c6e7abf
do not use sk_sp by reference
dnfield 085b43e
web
dnfield a6389a2
annotation
dnfield dedd872
review
dnfield 7c331a1
max iterations on test
dnfield db97f79
delay
dnfield 6fe3223
size
dnfield 7e6e3be
safe
dnfield fbc66d9
Work around for https://github.com/dart-lang/sdk/issues/49332
dnfield 1e22e7c
fix 32 bit builds
dnfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very sure how shall we use this new API to reuse expensive drawings across frames. Is there an example? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that would probably come at a higher level in the framework or in a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I can contribute once I understand it.