Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move the args for GLContextPresent into a struct#33758

Merged
iskakaushik merged 1 commit intoflutter:mainfrom
iskakaushik:present-info-struct
Jun 2, 2022
Merged

Move the args for GLContextPresent into a struct#33758
iskakaushik merged 1 commit intoflutter:mainfrom
iskakaushik:present-info-struct

Conversation

@iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Jun 1, 2022

This refactor enables easier additions to the method for fields that can be optionally consumed by various platforms.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 1, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@iskakaushik iskakaushik force-pushed the present-info-struct branch from fc9b98a to 954e85d Compare June 1, 2022 19:21
@iskakaushik iskakaushik requested a review from dnfield June 1, 2022 19:22
@Hixie
Copy link
Contributor

Hixie commented Jun 1, 2022

test-exempt: code refactor with no semantic change

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 1, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jun 1, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 1, 2022
@iskakaushik
Move the args for GLContextPresent into a struct
4f8569b 
This refactor enables easier additions to the method
for fields that can be optionally consumed by various
platforms.
@iskakaushik iskakaushik force-pushed the present-info-struct branch from 954e85d to 4f8569b Compare June 1, 2022 20:40
@iskakaushik iskakaushik merged commit f497996 into flutter:main Jun 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
f497996 Move the args for GLContextPresent into a struct (flutter/e…
aa418ac 
…ngine#33758)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@iskakaushik @houhuayong
Move the args for GLContextPresent into a struct (flutter#33758)
277fab1 
This refactor enables easier additions to the method
for fields that can be optionally consumed by various
platforms.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API needs tests platform-android platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iskakaushik @Hixie @fluttergithubbot @dnfield