[Impeller] OpenGL texture parameters on the right texture target.#33893
[Impeller] OpenGL texture parameters on the right texture target.#33893chinmaygarde merged 1 commit intoflutter:mainfrom
Conversation
We would bind the texture target as either a 2D or Cube type but only set parameters such as min/mag filters and wrap modes on the 2D target. This fixes the rendering the Impeller showcase with the OpenGL backend. Fixes flutter/flutter#104786
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Doh! How did you end up working it out? Just taking another look around? This issue had me scratching my head last week. |
|
Took a look at the test in Angle that sets up a cube texture. It's a nice reduced test case that fits in one screenful of code. Then just made sure we were doing similar things. Since there were no GL, ASAN, MSAN errors, figured it was just user error. |
…utter#33893) We would bind the texture target as either a 2D or Cube type but only set parameters such as min/mag filters and wrap modes on the 2D target. This fixes the rendering the Impeller showcase with the OpenGL backend. Fixes flutter/flutter#104786
3 participants
We would bind the texture target as either a 2D or Cube type but only set
parameters such as min/mag filters and wrap modes on the 2D target. This fixes
the rendering the Impeller showcase with the OpenGL backend.
Fixes flutter/flutter#104786
