[Impeller] Fix bindings for Solid Stroke wrt to the GLES backend#33908
[Impeller] Fix bindings for Solid Stroke wrt to the GLES backend#33908bdero merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Ah, I see whats happening and ImpellerC definitely has all the information necessary to halt on this issue. Landing this is fine but can you also file another issue to make this make ImpellerC do the right thing please?
|
SGTM. I corrected the bug what was attempting to target the underlying issue: flutter/flutter#105156 |
2 participants
Make the binding layout work correctly with the GLES backend (as per flutter/flutter#105156). I think we need to either make this situation error out in impellerc or make the binding layout behave correctly when there are multiple slots.
Linux before (proprietary nvidia):
Linux after (proprietary nvidia):
