Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Start uploading artifacts to GCS.#33970

Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom
godofredoc:update_gn_artifacts_gcs
Jun 13, 2022
Merged

Start uploading artifacts to GCS.#33970
fluttergithubbot merged 2 commits intoflutter:mainfrom
godofredoc:update_gn_artifacts_gcs

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 10, 2022

This is required to start testing the gn artifacts with the integration
tests of flutter framework.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Start uploading artifacts to GCS.
35d6d11 
This is required to start testing the gn artifacts with the integration
tests of flutter framework.

Bug: flutter/flutter#81855
@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 10, 2022

\cc @drewroengoogle @XilaiZhang

zanderso
zanderso reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be GitHub, but the indentation looks funky.

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 10, 2022

Might be GitHub, but the indentation looks funky.

Yeah, I ran python -m json.tool to auto indent

Might be GitHub, but the indentation looks funky.

They were indented using python -m json.tool <file> do we use a different tool to indent json in the engine?

christopherfujino
christopherfujino approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@zanderso
Copy link
Member

zanderso commented Jun 11, 2022

Might be GitHub, but the indentation looks funky.

Yeah, I ran python -m json.tool to auto indent

Might be GitHub, but the indentation looks funky.

They were indented using python -m json.tool <file> do we use a different tool to indent json in the engine?

We don't use any tool. I'm on mobile since I'm OOO, so I'm not sure I trust what it's showing me, but it looks like a tabs/spaces confusion.

@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 12, 2022

We don't use any tool. I'm on mobile since I'm OOO, so I'm not sure I trust what it's showing me, but it looks like a tabs/spaces confusion.

Ahh yeah, there are tabs here.

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 13, 2022

Found the tabs and replaced them with white spaces.

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 13, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 13, 2022

Still LGTM!

XilaiZhang
XilaiZhang approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow good eye on this to detect tabs


images (1)

@fluttergithubbot fluttergithubbot merged commit d792826 into flutter:main Jun 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
d792826 Start uploading artifacts to GCS. (flutter/engine#33970)
5886ff1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
d792826 Start uploading artifacts to GCS. (flutter/engine#33970)
b481ffd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
d792826 Start uploading artifacts to GCS. (flutter/engine#33970)
2d029b5
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@godofredoc @houhuayong
Start uploading artifacts to GCS. (flutter#33970)
90c111e
@godofredoc godofredoc deleted the update_gn_artifacts_gcs branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@zanderso zanderso zanderso left review comments

@christopherfujino christopherfujino christopherfujino approved these changes

@XilaiZhang XilaiZhang XilaiZhang approved these changes

@drewroengoogle drewroengoogle drewroengoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@godofredoc @zanderso @christopherfujino @XilaiZhang @drewroengoogle @fluttergithubbot