This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[MacOS] Accept first mouse-down #34093
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom Jun 23, 2022
Merged
Conversation
chinmaygarde
approved these changes
Jun 23, 2022
dnfield
approved these changes
Jun 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
This was referenced Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#88915
Overriding the
NSViewmethodacceptsFirstMousewill allow the initial mouse-down event when the window is not focused to pass to the view.Since not all developers may want this, this could ideally be a settable control, but this behavior at least matches Windows. It would also be possible for a developer to simulate this behavior in their application.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.