Re-Enable ExternalTexturesTest#34118
Conversation
On Q+ we need the format of the Surface to change. This used to happen for us when enqueuing images? Now it no longer happens.
|
Gold has detected about 6 new digest(s) on patchset 8. |
|
Gold has detected about 7 new digest(s) on patchset 9. |
|
Gold has detected about 8 new digest(s) on patchset 10. |
|
Gold has detected about 8 new digest(s) on patchset 12. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
3 participants
Re-Enable External Texture Tests.
These broke because on Android Q+, the behavior of ImageReader and ImageWriter have changed. Previously I think they did copies internally (somewhere), but now they are zero copy. This PR uses the "private" image format and hints to the Surface's producer that the images will be sampled by the GPU.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.