cleanup fractional translation ifdefs and config#34198
cleanup fractional translation ifdefs and config#34198jonahwilliams merged 3 commits intoflutter:mainfrom
Conversation
jonahwilliams
changed the title
|
Gold has detected about 1 new digest(s) on patchset 3. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM
It would be ideal to make sure we haven't regressed customer:money's benchmarks with this change, although they're currently in a sad state. I'm not sure how long it will take to get that better, but we should reach out to them before landing this to make sure.
|
we can always re-revert 😄 |
3 participants
flutter/flutter#103909
Holding off on landing this until we confirm there are no major performance regressions from removing pixel snapping from mobile