Remove unactionable verbose log about ignored viewport metrics.#34231
Remove unactionable verbose log about ignored viewport metrics.#34231fluttergithubbot merged 1 commit intoflutter:mainfrom
Conversation
This isn't useful the end user or the Flutter engine developer. I suspect this was left in the codebase for so long because not too many folks run an unopt engine.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
waiting for tree to go green
|
I think when I added this I was under the impression it happened rarely and could be avoided - but later realized it happens because on Android in particular we get updates in pieces and the embedding always tries to do a full update on each piece and forgot to remove the log. LGTM. |
5 participants
This isn't useful the end user or the Flutter engine developer. I suspect this
was left in the codebase for so long because not too many folks run an unopt
engine.