This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Limit coverage of all subpasses to the root texture#34246
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Jun 24, 2022
Merged
[Impeller] Limit coverage of all subpasses to the root texture#34246auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
dnfield
approved these changes
Jun 24, 2022
Contributor
Author
|
Note: For some blend modes (Clear, Source, SourceIn, DestinationIn, SourceOut, DestinationATop, and Modulate), the pass coverage should always expand to cover the root pass. I'll be adding this in a follow-up (there are other scenarios where we don't behave quite correctly because of this). |
bdero
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also factors the root pass coverage into the per-entity computation.
Consider a situation where the framework asks to render a path using an advanced blend, but the origin of the coverage of the path is -10000 pixels in the y direction for whatever reason. Absent of this change, the offscreen advanced blend texture ends up with a height of >11000 pixels. With this change, such an element will get excluded during the EntityPass coverage routine, which will cause the pass itself to have no coverage, which will cause the pass to get skipped.