This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Windows: IME window follows left edge of composing text, to match native Windows apps.#34292
Merged
cbracken merged 1 commit intoflutter:mainfrom Jun 30, 2022
Merged
Conversation
…ive Windows apps.
cbracken
approved these changes
Jun 30, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Thank you for correcting this! This was an error on my part when I first implemented this for Windows, and copied the expected macOS behaviour rather than implementing native Windows behaviour. It's been bothering me for a while, but I never got around to fixing it. This is really nice improvement, thanks!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2022
…atch native Windows apps. (flutter/engine#34292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextInputPlugin::GetCursorRectreturns by removing parallel transformation which adds width and height.I tested on Japanese Microsoft IME, Google Japanese Input and ATOK.
Fixes flutter/flutter#106555.
No changes in the flutter/tests repo.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.