This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Minimally crop advanced blends in EntityPass#34347
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Jun 28, 2022
Merged
[Impeller] Minimally crop advanced blends in EntityPass#34347auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
dnfield
approved these changes
Jun 28, 2022
bdero
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior for the blend filter is to union the coverage of all the inputs. Without this change, the advanced blend filter's output ends up always being the full size of the input destination texture. This is wasteful because EntityPass immediately blits the blend filter's output back onto the pass backdrop texture, and so for non-destructive blends, we only need to compute the blend within the source input's coverage.
Add
FilterContents::SetCoverageCrop()and use it inEntityPassto exclude the backdrop texture coverage for advanced blends.Note that all destructive blend modes (Clear, Source, SourceIn, DestinationIn, SourceOut, DestinationATop, and Modulate) are pipeline blends, and so this cropping behavior should always be safe.