Fix tests on the Windows platform#34350
Fix tests on the Windows platform#34350loic-sharma merged 16 commits intoflutter:mainfrom mtolmacs:windows-fix-tests
Conversation
and removing feature gate on tests for Windows
the std::fstream::binary flag
|
Gold has detected about 1 new digest(s) on patchset 2. |
flutter_tester on Windows
|
Gold has detected about 1 new digest(s) on patchset 3. |
that fixes skia gold issue.
|
Gold has detected about 1 new digest(s) on patchset 4. |
where it did not solve the issue the original commit tries to fix
before loading the platform image decoders
|
Gold has detected about 1 new digest(s) on patchset 8. |
Co-authored-by: Loïc Sharma <[email protected]>
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for your contribution, this is awesome ❤️
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
I'm no Windows expert but I see no problems with this. It's great that we'll be able to run these locally now.
|
Gold has detected about 1 new digest(s) on patchset 16. |
5 participants
The aim of this PR is to allow successfully running all non-disabled dart and engine tests on local Windows, so engine development can happen on Windows machines proper.
Issues fixed by this PR
Changes to flutter/tests
This PR does not affect flutter/tests
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.