This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add post-processed dart files to web_sdk.#34357
Merged
auto-submit[bot] merged 1 commit intomainfrom Jun 28, 2022
Merged
Conversation
The gn target was using pre-processed files in the web_sdk bundle which was causing issues with import statements. This PR is using the already processed files with the correct import statements. Bug: flutter/flutter#81855
flutter-dashboard
bot
added
the
platform-web
eyebrowsoffire
approved these changes
Jun 28, 2022
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Awesome! Just a minor nitpick but otherwise looks good to me.
| outputs = [ "$target_gen_dir/$target_name.stamp" ] | ||
| outputs = [ | ||
| "$target_gen_dir/$target_name.stamp", | ||
| "$root_out_dir/flutter_web_sdk/lib/_engine/", |
Contributor
There was a problem hiding this comment.
I think you can just use the $output_dir variable here, right?
Contributor
Author
There was a problem hiding this comment.
Using $output_dir is returning the following error:
ERROR at //flutter/web_sdk/BUILD.gn:57:5: File is not inside output directory.
"$output_dir",
^------------
The given file should be in the output directory. Normally you would specify
"$target_out_dir/foo" or "$target_gen_dir/foo". I interpreted this as
"/usr/local/google/home/godofredoc/flutter/engine/src/out/host_debug/flutter_web_sdk/lib/ui/".
| outputs = [ "$target_gen_dir/$target_name.stamp" ] | ||
| outputs = [ | ||
| "$target_gen_dir/$target_name.stamp", | ||
| "$root_out_dir/flutter_web_sdk/lib/ui/", |
yjbanov
approved these changes
Jun 28, 2022
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gn target was using pre-processed files in the web_sdk bundle which
was causing issues with import statements. This PR is using the already
processed files with the correct import statements.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.