Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Add new pointer signal for cancelling scroll inertia"#34537

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
moffatman:inertia_prep3
Jul 14, 2022
Merged

Reland "Add new pointer signal for cancelling scroll inertia"#34537
auto-submit[bot] merged 3 commits intoflutter:mainfrom
moffatman:inertia_prep3

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Jul 8, 2022

Relands #34402 which was reverted in #34535

Also update enums of android and web which were missed in the original PR.

It's expected behaviour on some platforms that scroll inertia/momentum animations will stop when a finger is rested on the trackpad. This PR introduces a new kind of pointer signal event which will be used to transmit that message.

Blocked on: flutter/flutter#106906

Framework PR: flutter/flutter#106891

Engine PRs for iPadOS, macOS, and Win32 to follow

Part of flutter/flutter#106979

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android platform-web Code specifically for the web engine labels Jul 8, 2022
@moffatman moffatman mentioned this pull request Jul 8, 2022
Merged
dkwingsmt
dkwingsmt approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jul 13, 2022

The prerequisite PR has bee rolled in. Can you rebase this PR and let's merge it again?

@dkwingsmt dkwingsmt mentioned this pull request Jul 13, 2022
Merged
8 tasks
@moffatman moffatman added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. autosubmit Merge PR when tree becomes green via auto submit App and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jul 14, 2022
@auto-submit auto-submit bot merged commit eb4e184 into flutter:main Jul 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2022
@engine-flutter-autoroll
eb4e184 Reland "Add new pointer signal for cancelling scroll inertia" (…
72c20e2 
…flutter/engine#34537)
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@moffatman @betrevisan
Reland "Add new pointer signal for cancelling scroll inertia" (flutte…
b4b17b0 
…r#34537)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-android platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moffatman @dkwingsmt