This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set the 'visibility' of 'FlutterView' to the previous one in 'FragmentActivityAndFragment.onStart'#34601
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Jul 12, 2022
Conversation
…tActivityAndFragment.onStart'
Nayuta403
reviewed
Jul 12, 2022
| // onStart and onStop. | ||
| // See https://github.com/flutter/flutter/issues/93276 | ||
| flutterView.setVisibility(View.GONE); | ||
| if (flutterView.getVisibility() != View.GONE) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (flutterView.getVisibility() != View.GONE) { |
I wonder if this judgment can be removed, or previousVisibility needs to be assigned again in else.
So let's say this is the case：
- First time the flutterView is
View.VISIBLE. WhenonStopis executed,previousVisibilitywill also becomeView.VISIBLE. - Second time I change the flutterView to
View.GONE. WhenonStopis executed, thepreviousVisibilitywill not be changed.
If onStart is executed at this time, previousVisibility remains as before, causes the flutterView to be View.VISIBLE（Even though I've changed to View.GONE）
Member
Author
There was a problem hiding this comment.
Good catch! I'll remove it.
dnfield
approved these changes
Jul 12, 2022
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2022
…'FragmentActivityAndFragment.onStart' (flutter/engine#34601)
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
…tActivityAndFragment.onStart' (flutter#34601)
|
issues/105203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#105203
Pre-launch Checklist
writing and running engine tests.
///).