[dart runner] Remove unused use statements from dart runner manifest.#34652
[dart runner] Remove unused use statements from dart runner manifest.#34652naudzghebre merged 1 commit intoflutter:mainfrom
Conversation
akbiggs
left a comment
There was a problem hiding this comment.
How did we verify these are unused? I know we were told they shouldn't be used by V2 but just wondering what components we tested with.
|
Well, I was the one that added Environment and Loader to the jit runner's manifest, sort of unnecessarily, when I was trying to model the runner after the legacy_test_runner, but the runners aren't using those services directly. And config-data I see is being used for v1/v2 components under the flutter runner but not the dart runner. In fuchsia.git only workstation is routing config-data to the dart runner, but i believe this is because we have the use declaration here. |
|
My understanding is components that access "/config/data" need config-data, which we don't do in the dart_runner. |
No description provided.