Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Check for shader data validity and add tests#34793

Merged
zanderso merged 1 commit intoflutter:mainfrom
zanderso:fp-crash
Jul 21, 2022
Merged

Check for shader data validity and add tests#34793
zanderso merged 1 commit intoflutter:mainfrom
zanderso:fp-crash

Conversation

@zanderso
Copy link
Member

Fixes flutter/flutter#108037 as stated. We probably need separate issues for the other problems mentioned in the comments of that issue.

@zanderso zanderso requested a review from jonahwilliams July 20, 2022 20:13
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing invalid shader asset to ui.FragmentProgram.fromAsset crashes application

2 participants