This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
cbracken
approved these changes
Jul 26, 2022
Member
There was a problem hiding this comment.
Assuming this behaves itself, we should consider also flipping the gn batch script and shebang line:
- https://github.com/flutter/engine/blob/main/tools/gn.bat
- https://github.com/flutter/engine/blob/main/tools/gn#L1
Please keep an eye on the post-submit, since it runs a lot more stuff than the pre-submit.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2022
* 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
This was referenced Jul 27, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…8392) * 125a4b4 Roll Skia from c334e0933076 to a9d44a41296f (1 revision) (flutter/engine#34909) * 763feb4 Roll Skia from a9d44a41296f to b7e27876f093 (1 revision) (flutter/engine#34911) * 9388b8e [Impeller] [vulkan] Wire-up creating pipeline (flutter/engine#34890) * bdcc960 Roll buildroot deps (flutter/engine#34894) * 9a86864 Roll Dart SDK from c77db322733f to 52c6d32a67b6 (1 revision) (flutter/engine#34914) * 1a9eb88 Roll Fuchsia Linux SDK from JG8eZzFic... to 4xjxrGUrD... (flutter/engine#34915) * 4c613a6 Remove the OpenGL backend on iOS (flutter/engine#34913)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finally lands flutter/buildroot#590. Originally attempted in flutter/buildroot#501, but reverted in flutter/buildroot#507.
Description (flutter/flutter#88719)
Rolling the revert in flutter/buildroot#507 breaks the Fuchsia build, which requires a Python 3 distribution that includes the yaml module. Instead, @cbracken landed #28314, which enables vpython3 for runs of the gn wrapper on Windows, via the gn.bat batch script. That seems to have eliminated the flakiness we were seeing on the engine Windows bots.
Pre-launch Checklist
writing and running engine tests.
///).