Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Clang and Abseil#34953

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:roll_abseil_072722
Jul 28, 2022
Merged

Roll Clang and Abseil#34953
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:roll_abseil_072722

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jul 27, 2022

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
@auto-submit auto-submit bot merged commit 862773f into flutter:main Jul 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
862773f Roll Clang and Abseil (flutter/engine#34953)
31e2f40
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 29, 2022
@jason-simmons @betrevisan
Roll Clang and Abseil (flutter#34953)
06d53b8
@whesse
Copy link
Contributor

whesse commented Aug 1, 2022 •
edited
Loading

This change is causing a failure on Mac iOS compilation. The flag -Wno-deprecated-builtins is being used, but it is not in the clang used by a builder with --no-goma and --simulator-cpu=arm64:
More details are posted in the bug flutter/flutter#108388

[3415/5770] CXX clang_x64/obj/third_party/abseil-cpp/absl/strings/internal/strings.memutil.o
FAILED: clang_x64/obj/third_party/abseil-cpp/absl/strings/internal/strings.memutil.o 
clang++ -MD -MF clang_x64/obj/third_party/abseil-cpp/absl/strings/internal/strings.memutil.o.d -DUSE_OPENSSL=1 -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DABSL_ALLOCATOR_NOTHROW=1 -I../.. -Iclang_x64/gen -I../../third_party/libcxx/include -I../../third_party/libcxxabi/include -I../../build/secondary/third_party/libcxx/config -I../../third_party/abseil-cpp -isysroot /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -mmacosx-version-min=10.13.0 -fno-strict-aliasing -fstack-protector-all -arch x86_64 -fcolor-diagnostics -fvisibility=hidden -stdlib=libc++ -Wstring-conversion -Wnewline-eof -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -Wno-newline-eof -Wno-typedef-redefinition -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wunguarded-availability -Wno-deprecated-declarations -fvisibility-inlines-hidden -std=c++17 -fno-rtti -nostdinc++ -nostdinc++ -fvisibility=hidden -fno-exceptions -Wno-newline-eof -Wbool-conversion -Wconstant-conversion -Wenum-conversion -Wint-conversion -Wliteral-conversion -Wnon-literal-null-conversion -Wnull-conversion -Wobjc-literal-conversion -Wno-sign-conversion -Wstring-conversion -Wbitfield-enum-conversion -Wno-deprecated-builtins  -c ../../third_party/abseil-cpp/absl/strings/internal/memutil.cc -o clang_x64/obj/third_party/abseil-cpp/absl/strings/internal/strings.memutil.o
error: unknown warning option '-Wno-deprecated-builtins'; did you mean '-Wno-deprecated-volatile'? [-Werror,-Wunknown-warning-option]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

//third-party/abseil-cpp emitting warnings

3 participants

@jason-simmons @whesse @chinmaygarde