Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix paths of mac_host_engine artifacts.#34984

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:fix_mac_host_engine_paths
Jul 28, 2022
Merged

Fix paths of mac_host_engine artifacts.#34984
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:fix_mac_host_engine_paths

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jul 28, 2022

Artifacts for profiles other than debug include the profile name as part
of the path.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Fix paths of mac_host_engine artifacts.
c336f67 
Artifacts for profiles other than debug include the profile name as part
of the path.
XilaiZhang
XilaiZhang approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I messed up the naming. Thanks for correcting!

images (1)

christopherfujino
christopherfujino approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
@auto-submit auto-submit bot merged commit 9624d86 into flutter:main Jul 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
9624d86 Fix paths of mac_host_engine artifacts. (flutter/engine#34984)
a128936
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 29, 2022
@godofredoc @betrevisan
Fix paths of mac_host_engine artifacts. (flutter#34984)
a0d9ae9
@godofredoc godofredoc deleted the fix_mac_host_engine_paths branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @christopherfujino @XilaiZhang