This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate Win32 suffixes in KeyboardManager#35008
Merged
cbracken merged 1 commit intoflutter:mainfrom Jul 29, 2022
cbracken:keyboard-manager-win32
Merged
Eliminate Win32 suffixes in KeyboardManager#35008cbracken merged 1 commit intoflutter:mainfrom cbracken:keyboard-manager-win32
cbracken merged 1 commit intoflutter:mainfrom
cbracken:keyboard-manager-win32
Conversation
cbracken
requested review from
dkwingsmt,
gspencergoog,
loic-sharma and
yaakovschectman
This renames KeyboardManagerWin32 to KeyboardManager and updates all
usage sites and tests.
This is a followup to 89bbfcc, which applied most of the straightforward
renamings of FooWin32 to Foo (or where a superclass Foo exists,
FooWindows) to the Windows embedding. In that patch I missed
KeyboardManagerWin32, as well as two straightforward file renames:
* keyboard_win32_common.{h,cc} -> keyboard_utils.{h,cc}
* system_utils_win32.cc -> system_utils.cc
Issue: flutter/flutter#108386
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This renames KeyboardManagerWin32 to KeyboardManager and updates all
usage sites and tests.
This is a followup to 89bbfcc, which applied most of the straightforward
renamings of FooWin32 to Foo (or where a superclass Foo exists,
FooWindows) to the Windows embedding. In that patch I missed
KeyboardManagerWin32, as well as two straightforward file renames:
* keyboard_win32_common.{h,cc} -> keyboard_utils.{h,cc}
* system_utils_win32.cc -> system_utils.cc
No new tests since this is a rename with no semantic change intended.
Issue: flutter/flutter#108386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames KeyboardManagerWin32 to KeyboardManager and updates all
usage sites and tests.
This is a followup to 89bbfcc, which applied most of the straightforward
renamings of FooWin32 to Foo (or where a superclass Foo exists,
FooWindows) to the Windows embedding. In that patch I missed
KeyboardManagerWin32, as well as two straightforward file renames:
No new tests since this is a rename with no semantic change intended.
Issue: flutter/flutter#108386
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.