This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't insist on modules when attempting to include the Flutter umbrella header.#35060
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Aug 1, 2022
Merged
Conversation
…la header.
This fixes local engine builds on Mac. The `copy_and_verify_framework_module`
exists to ensure that the umbrella header can be cleanly imported from an ObjC
TU. However, the compile flags insist on module support being enabled. It isn't
clear how this used to work earlier since no modules were provided. Likely, this
was a race. Remove the insistence on modules because that wasn't the intent of
creating the target in the first place.
The issue fixed is the following:
```
/Users/chinmaygarde/VersionControlled/depot_tools/.cipd_bin/gomacc ../../buildtools/mac-x64/clang/bin/clang++ -MD -MF obj/flutter/shell/platform/darwin/ios/framework/Source/libcopy_and_verify_framework_module.FlutterUmbrellaImport.o.d -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_DEBUG -I../.. -Igen -isysroot /Users/chinmaygarde/VersionControlled/engine/src/out/ios_debug_unopt/gen/SDKs/iPhoneOS15.5.sdk -miphoneos-version-min=11.0 -fno-strict-aliasing -arch arm64 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-unused-but-set-variable -Wno-implicit-int-float-conversion -Wno-c99-designator -Wno-deprecated-copy -Wno-psabi -Wno-unqualified-std-cast-call -Wno-non-c-typedef-for-linkage -Wno-range-loop-construct -Wunguarded-availability -Wno-deprecated-declarations -fvisibility=hidden -stdlib=libc++ -Wstring-conversion -Wnewline-eof -O0 -g2 -F/Users/chinmaygarde/VersionControlled/engine/src/out/ios_debug_unopt -fmodules -Wnon-modular-include-in-framework-module -c ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUmbrellaImport.m -o obj/flutter/shell/platform/darwin/ios/framework/Source/libcopy_and_verify_framework_module.FlutterUmbrellaImport.o
../../flutter/shell/platform/darwin/ios/framework/Source/FlutterUmbrellaImport.m:11:9: fatal error: module 'Flutter' is needed but has not been provided, and implicit use of module files is disabled
^
1 error generated.
```
Contributor
Author
|
So, I haven't investigated why this didn't happen earlier. But I did change default goma job counts recently? In any case, if we need to test the umbrella header, we don't want modules. |
zanderso
approved these changes
Aug 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2022
…r umbrella header. (flutter/engine#35060)
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes local engine builds on Mac. The
copy_and_verify_framework_moduleexists to ensure that the umbrella header can be cleanly imported from an ObjC
TU. However, the compile flags insist on module support being enabled. It isn't
clear how this used to work earlier since no modules were provided. Likely, this
was a race. Remove the insistence on modules because that wasn't the intent of
creating the target in the first place.
The issue fixed is the following: