Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| // this script (the first set for _canonicalizeLanguageCode and the second set | ||
| // for _canonicalizeRegionCode). | ||
|
|
||
| // ignore_for_file: avoid_print |
There was a problem hiding this comment.
This shouldn't be necessary since there's a global opt-out for the tools directory in https://github.com/flutter/engine/blob/main/tools/analysis_options.yaml.
There was a problem hiding this comment.
My IDE was complaining about this but maybe it wasn't properly configured?
|
test-exempt: code refactor with no semantic change |
3 participants
flutter/flutter#108933
Tested manually by running the script and making sure it produces same output before and after.